Comments on: Observation: Code cleverness == Bad

By: Sidu

Sidu — Wed, 27 Feb 2008 08:45:30 +0000

Not to mention the fact that it’s hard to test that big blob of generated code. Meta-programmatically generating untestable code is the path to the dark side.

By: Jeremy Friesen

Jeremy Friesen — Wed, 02 May 2007 20:56:17 +0000

Agreed, too much work in a single method is a dangerous thing.

By: brink

brink — Wed, 02 May 2007 20:44:02 +0000

Thanks, yeah I got that particular issue solved, however it also has a bug at the end on the delete_if, which fails if there are no actual results of the preceding block.

My point is that the code is too clever. It’s not immediately obvious that there are bugs in it, because it’s obfuscated by the concatenation of methods.

Don’t get me wrong, it sort of appeals to me to have an essential one-liner, but more and more I’m of the opinion that verbosity is better in the long run.

By: Jeremy Friesen

Jeremy Friesen — Wed, 02 May 2007 20:28:37 +0000

I believe I see your problem, its with the inject statement; the last line of inject must return the mem variable.

No Worky
[1,2,nil,3].inject([]) do |m,v|
m